From: Chad Hanson <chanson@trustedcs.com>
Date: Mon, 23 Dec 2013 22:45:01 +0000 (-0500)
Subject: selinux: fix broken peer recv check
X-Git-Url: http://git.mmlx.us/?a=commitdiff_plain;h=faecbbe4213acc9da2aa44d0577cad1a9f419946;p=linux-edison.git

selinux: fix broken peer recv check

commit 46d01d63221c3508421dd72ff9c879f61053cffc upstream.

Fix a broken networking check. Return an error if peer recv fails.  If
secmark is active and the packet recv succeeds the peer recv error is
ignored.

Signed-off-by: Chad Hanson <chanson@trustedcs.com>
Signed-off-by: Paul Moore <pmoore@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 5e58d7dd7b6..57a7b362c86 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -4228,8 +4228,10 @@ static int selinux_socket_sock_rcv_skb(struct sock *sk, struct sk_buff *skb)
 		}
 		err = avc_has_perm(sk_sid, peer_sid, SECCLASS_PEER,
 				   PEER__RECV, &ad);
-		if (err)
+		if (err) {
 			selinux_netlbl_err(skb, err, 0);
+			return err;
+		}
 	}
 
 	if (secmark_active) {