From: Stephen M. Cameron Date: Mon, 23 Sep 2013 18:33:41 +0000 (-0500) Subject: SCSI: hpsa: do not discard scsi status on aborted commands X-Git-Url: http://git.mmlx.us/?a=commitdiff_plain;h=f9c848e607ca4ac52a35ac56402989505dd61a23;p=linux-edison.git SCSI: hpsa: do not discard scsi status on aborted commands commit 2e311fbabdc23b7eaec77313dc3b9a151a5407b5 upstream. We inadvertantly discarded the scsi status for aborted commands. For some commands (e.g. reads from tape drives) these can't be retried, and if we discarded the scsi status, the scsi mid layer couldn't notice anything was wrong and the error was not reported. Signed-off-by: Stephen M. Cameron Signed-off-by: James Bottomley Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 7f4f790a3d7..603ef4961d3 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -1265,7 +1265,7 @@ static void complete_scsi_command(struct CommandList *cp) "has check condition: aborted command: " "ASC: 0x%x, ASCQ: 0x%x\n", cp, asc, ascq); - cmd->result = DID_SOFT_ERROR << 16; + cmd->result |= DID_SOFT_ERROR << 16; break; } /* Must be some other type of check condition */