From: David Woodhouse <dwmw2@shinybook.infradead.org>
Date: Fri, 24 Jun 2005 07:21:49 +0000 (+0100)
Subject: AUDIT: Return correct result from audit_filter_rules()
X-Git-Url: http://git.mmlx.us/?a=commitdiff_plain;h=993e2d4106e94dae6e8cfbeb32073bd12cdee203;p=linux-edison.git

AUDIT: Return correct result from audit_filter_rules()

When the task refcounting was added to audit_filter_rules() it became
more of a problem that this function was violating the 'only one
return from each function' rule. In fixing it to use a variable to store
'ret' I stupidly neglected to actually change the 'return 1;' at the
end. This makes it not work very well.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
---

diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 20c7d8560af..7b123f0a948 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -557,7 +557,7 @@ int audit_filter_user(int pid, int type)
 	rcu_read_unlock();
 	put_task_struct(tsk);
 
-	return 1; /* Audit by default */
+	return ret; /* Audit by default */
 
 }