From: Andi Kleen Date: Tue, 1 Jun 2010 21:04:40 +0000 (+0200) Subject: USB-BKL: Remove lock_kernel in usbfs update_sb() X-Git-Url: http://git.mmlx.us/?a=commitdiff_plain;h=6e12ea4658487ba9c746e95b31014cb89f63703b;p=linux-edison.git USB-BKL: Remove lock_kernel in usbfs update_sb() The code this is attempting to lock against does not use the BKL, so it's not needed. Most likely this code is still broken/racy (Al Viro also thinks so), but removing the BKL should not make it worse than before. Signed-off-by: Andi Kleen Cc: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/core/inode.c b/drivers/usb/core/inode.c index 1a27618b67d..095fa536669 100644 --- a/drivers/usb/core/inode.c +++ b/drivers/usb/core/inode.c @@ -265,13 +265,9 @@ static int remount(struct super_block *sb, int *flags, char *data) return -EINVAL; } - lock_kernel(); - if (usbfs_mount && usbfs_mount->mnt_sb) update_sb(usbfs_mount->mnt_sb); - unlock_kernel(); - return 0; }