From: Dan Carpenter Date: Thu, 10 Jan 2013 08:57:25 +0000 (-0500) Subject: Btrfs: fix access_ok() check in btrfs_ioctl_send() X-Git-Url: http://git.mmlx.us/?a=commitdiff_plain;h=6b047827d4cdd57ac7c4f9da2d779d811649566f;p=linux-edison.git Btrfs: fix access_ok() check in btrfs_ioctl_send() commit 700ff4f095d78af0998953e922e041d75254518b upstream. The closing parenthesis is in the wrong place. We want to check "sizeof(*arg->clone_sources) * arg->clone_sources_count" instead of "sizeof(*arg->clone_sources * arg->clone_sources_count)". Signed-off-by: Dan Carpenter Reviewed-by: Jie Liu Signed-off-by: Chris Mason Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index 09ea0bdde65..256a9a46d54 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -4623,8 +4623,8 @@ long btrfs_ioctl_send(struct file *mnt_file, void __user *arg_) } if (!access_ok(VERIFY_READ, arg->clone_sources, - sizeof(*arg->clone_sources * - arg->clone_sources_count))) { + sizeof(*arg->clone_sources) * + arg->clone_sources_count)) { ret = -EFAULT; goto out; }