From: Johan Hovold Date: Mon, 26 Jan 2015 11:02:46 +0000 (+0100) Subject: gpio: sysfs: fix memory leak in gpiod_sysfs_set_active_low X-Git-Url: http://git.mmlx.us/?a=commitdiff_plain;h=4cd925d7c1d5d777f2f09db4aee4675d0978a95b;p=linux-edison.git gpio: sysfs: fix memory leak in gpiod_sysfs_set_active_low commit 49d2ca84e433dab854c7a866bc6add09cfab682d upstream. Fix memory leak in the gpio sysfs interface due to failure to drop reference to device returned by class_find_device when setting the gpio-line polarity. Fixes: 0769746183ca ("gpiolib: add support for changing value polarity in sysfs") Signed-off-by: Johan Hovold Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 6dd7df80ae2..ca1cb2d756c 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -928,7 +928,7 @@ static int gpiod_sysfs_set_active_low(struct gpio_desc *desc, int value) } status = sysfs_set_active_low(desc, dev, value); - + put_device(dev); unlock: mutex_unlock(&sysfs_lock);