From: Krzysztof Kozlowski Date: Fri, 20 Dec 2013 09:35:07 +0000 (+0100) Subject: mfd: max77686: Fix regmap resource leak on driver remove X-Git-Url: http://git.mmlx.us/?a=commitdiff_plain;h=33e2b2c73e78379dbb2db135c490ca8ca76bfd58;p=linux-edison.git mfd: max77686: Fix regmap resource leak on driver remove commit 74142ffc0b52cfe6f9d2f6f34a5f3eedbfe3ce51 upstream. The regmap used by max77686 MFD driver was not freed with regmap_exit() on driver exit. This lead to leak of resources. Replace regmap_init_i2c() call in driver probe with initialization of managed register map so the regmap will be properly freed by the device management code. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index 1cbb17609c8..8290c238239 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -102,7 +102,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c, max77686->irq_gpio = pdata->irq_gpio; max77686->irq = i2c->irq; - max77686->regmap = regmap_init_i2c(i2c, &max77686_regmap_config); + max77686->regmap = devm_regmap_init_i2c(i2c, &max77686_regmap_config); if (IS_ERR(max77686->regmap)) { ret = PTR_ERR(max77686->regmap); dev_err(max77686->dev, "Failed to allocate register map: %d\n",