sock_diag: off by one checks
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 7 Dec 2011 20:49:38 +0000 (20:49 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Dec 2011 00:58:35 +0000 (19:58 -0500)
These tests are off by one because sock_diag_handlers[] only has AF_MAX
elements.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Pavel Emelyanov <xemul@parallels.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/sock_diag.c

index fbaf01c..9c27bcd 100644 (file)
@@ -32,7 +32,7 @@ int sock_diag_register(struct sock_diag_handler *hndl)
 {
        int err = 0;
 
-       if (hndl->family > AF_MAX)
+       if (hndl->family >= AF_MAX)
                return -EINVAL;
 
        mutex_lock(&sock_diag_table_mutex);
@@ -50,7 +50,7 @@ void sock_diag_unregister(struct sock_diag_handler *hnld)
 {
        int family = hnld->family;
 
-       if (family > AF_MAX)
+       if (family >= AF_MAX)
                return;
 
        mutex_lock(&sock_diag_table_mutex);