usb: gadget serial: don't shift bcd version left by 16
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Mon, 10 Sep 2012 17:06:44 +0000 (19:06 +0200)
committerFelipe Balbi <balbi@ti.com>
Mon, 10 Sep 2012 17:04:20 +0000 (20:04 +0300)
Fengguang Wu reported:
|drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from
|constant value (24000000 becomes 0)

I obviously let the version number shift away. Since the version is a
16bit number it can be applied as it.

Cc: fengguang.wu@intel.com
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/serial.c

index 9420673..44752f5 100644 (file)
@@ -86,7 +86,7 @@ static struct usb_device_descriptor device_desc = {
        /* .bMaxPacketSize0 = f(hardware) */
        .idVendor =             cpu_to_le16(GS_VENDOR_ID),
        /* .idProduct = f(use_acm) */
-       .bcdDevice = cpu_to_le16(GS_VERSION_NUM << 16),
+       .bcdDevice = cpu_to_le16(GS_VERSION_NUM),
        /* .iManufacturer = DYNAMIC */
        /* .iProduct = DYNAMIC */
        .bNumConfigurations =   1,