cpuidle: kirkwood: fix coccicheck warnings
authorSilviu-Mihai Popescu <silviupopescu1990@gmail.com>
Fri, 22 Mar 2013 13:10:42 +0000 (14:10 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sun, 31 Mar 2013 23:10:27 +0000 (01:10 +0200)
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpuidle/cpuidle-kirkwood.c

index 670aa1e..53aad73 100644 (file)
@@ -66,9 +66,9 @@ static int kirkwood_cpuidle_probe(struct platform_device *pdev)
        if (res == NULL)
                return -EINVAL;
 
-       ddr_operation_base = devm_request_and_ioremap(&pdev->dev, res);
-       if (!ddr_operation_base)
-               return -EADDRNOTAVAIL;
+       ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
+       if (IS_ERR(ddr_operation_base))
+               return PTR_ERR(ddr_operation_base);
 
        device = &per_cpu(kirkwood_cpuidle_device, smp_processor_id());
        device->state_count = KIRKWOOD_MAX_STATES;