efivarfs: Make 'datasize' unsigned long
authorMatt Fleming <matt.fleming@intel.com>
Tue, 23 Oct 2012 11:35:43 +0000 (12:35 +0100)
committerMatt Fleming <matt.fleming@intel.com>
Tue, 30 Oct 2012 10:39:27 +0000 (10:39 +0000)
There's no reason to declare 'datasize' as an int, since the majority
of the functions it's passed to expect an unsigned long anyway. Plus,
this way we avoid any sign problems during arithmetic.

Acked-by: Jeremy Kerr <jeremy.kerr@canonical.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
drivers/firmware/efivars.c

index 3b0cf9a..6a858d1 100644 (file)
@@ -692,7 +692,7 @@ static ssize_t efivarfs_file_write(struct file *file,
        void *data;
        u32 attributes;
        struct inode *inode = file->f_mapping->host;
-       int datasize = count - sizeof(attributes);
+       unsigned long datasize = count - sizeof(attributes);
        unsigned long newdatasize;
 
        if (count < sizeof(attributes))