firewire: net: fix use after free
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Tue, 18 Feb 2014 21:25:15 +0000 (22:25 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Mar 2014 04:38:16 +0000 (21:38 -0700)
commitf5befc2c193dbe92826a382e16cb50e8640a4f62
tree0263351d1b42fe6b515c7e77a3a4fbd21f564174
parentd6a6d1f38ce55aa5a7d8aab972176660b19fd7ab
firewire: net: fix use after free

commit 8987583366ae9e03c306c2b7d73bdb952df1d08d upstream.

Commit 8408dc1c14c1 "firewire: net: use dev_printk API" introduced a
use-after-free in a failure path.  fwnet_transmit_packet_failed(ptask)
may free ptask, then the dev_err() call dereferenced it.  The fix is
straightforward; simply reorder the two calls.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firewire/net.c