be2net: remove wrong and unnecessary calls to netif_carrier_off()
authorSathya Perla <sathya.perla@emulex.com>
Tue, 2 Aug 2011 19:57:41 +0000 (19:57 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 3 Aug 2011 10:23:29 +0000 (03:23 -0700)
commitd09f698056a33c8b078497fb23e3304b6f8a908f
tree9d1be0be2f7ae5d60689e005b567efe74dd4b4ae
parenta9b3cd7f323b2e57593e7215362a7b02fc933e3a
be2net: remove wrong and unnecessary calls to netif_carrier_off()

1) In be_probe(), as soon as the MCC Q is created a gratuitous link status
event is received and processed. Accordingly netif_carrier_off/on() is called.
The extra netif_carrier_off() call in probe can race with this and cause wrong
state.

2) be_close() need not call netif_carrier_off(). It is OK to show the actual
link state even when the device is administratively down.

Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/benet/be_main.c